-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bounding box function and mirrorGrid changes #59
Conversation
I changed the mirror behavior so that the _mirror grids have the same trailing index as the original grid. I find this more useful when I am trying to map which block mirrors to which in tecplot etc |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 21.79% 21.89% +0.09%
==========================================
Files 3 3
Lines 2271 2279 +8
==========================================
+ Hits 495 499 +4
- Misses 1776 1780 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. One comment though:
…ment to the default mirror grid function
This PR replicates the changes in #58. The old PR was closed w/o merging because of conflicts I did not want to deal with.
Here, I added the method to get the bounding boxes from grids, which can be then used to fine tune the cartesian grid coordinates in: mdolab/pyhyp#65 I also made slight modifications to the mirror grid call because it was not working for what I needed to do. Finally, a new function to mirror surface grids (the default mirror only works on volume)
Purpose
Expected time until merged
few days
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable